Skip to content

feat(consensus): Add consensus check for block sequencing #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

feat(consensus): Add consensus check for block sequencing #231

merged 4 commits into from
Aug 5, 2025

Conversation

frisitano
Copy link
Collaborator

Overview

This PR introduces a should_sequence_block on the Consensus trait such that the manager can asses if the sequencer is authorized to sign a new block for a specific slot.

colinlyguo
colinlyguo previously approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After this PR, is an L1 node (with system contract slot correctly initialized) needed for local running?

colinlyguo
colinlyguo reviewed Aug 4, 2025
View reviewed changes
@frisitano
Copy link
Collaborator Author

LGTM. After this PR, is an L1 node (with system contract slot correctly initialized) needed for local running?

Not needed, you just have to be specific about how you configure the node. There are 2 ways you can configure the nodes such that L1 provider isn't needed:

  1. Set the consensus algorithm to be noop (--consensus.algorithm=noop)
  2. Set the consensus algorithm to be system-contract (this is default so no cli arguments requied) and then also set the authorized signer address --consensus.authorized-signer=ADDRESS)

frisitano
frisitano commented Aug 4, 2025
View reviewed changes
greged93
greged93 previously approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits but feel free to merge

@frisitano frisitano requested a review from greged93 August 5, 2025 10:38
greged93
greged93 approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano enabled auto-merge (squash) August 5, 2025 10:50
@frisitano frisitano merged commit 5b57c32 into main Aug 5, 2025
13 checks passed
@frisitano frisitano deleted the feat/sequencer-consensus branch August 5, 2025 10:52
@frisitano frisitano mentioned this pull request Aug 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinlyguo colinlyguo colinlyguo left review comments

@greged93 greged93 greged93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frisitano @greged93 @colinlyguo